Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multimarkdown: new recipe #3504

Merged
merged 11 commits into from Jan 4, 2019
Merged

multimarkdown: new recipe #3504

merged 11 commits into from Jan 4, 2019

Conversation

hanya
Copy link
Contributor

@hanya hanya commented Dec 25, 2018

fix #3172

@Begasus
Copy link
Contributor

Begasus commented Dec 25, 2018

LGTM, could someone else confirm?

alaviss
alaviss reviewed Dec 26, 2018
View reviewed changes
Copy link
Contributor

@alaviss alaviss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed that there's a test suite in the source code and all of the tests failed. Can you check up on that? You can run the testsuite with make test

app-text/multimarkdown/multimarkdown-6.4.0.recipe Show resolved Hide resolved
app-text/multimarkdown/multimarkdown-6.4.0.recipe Outdated Show resolved Hide resolved
@waddlesplash waddlesplash merged commit 2c4a885 into haikuports:master Jan 4, 2019
@waddlesplash
Copy link
Member

Thanks!

@hanya hanya deleted the multimarkdown branch January 5, 2019 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaviss alaviss alaviss left review comments

@Begasus Begasus Begasus left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add recipe for multimarkdown
4 participants
@hanya @Begasus @waddlesplash @alaviss