New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipe for BamKeys. #3535
Recipe for BamKeys. #3535
Conversation
@humdingerb Done. |
@humdingerb Can you check the other PR I made for bamkeys repo? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this recipe does not use a tagged source, please use 1.0.0_<date of chosen commit in yyyymmdd>
as the version.
Looks good. It does fix the build. As alaviss said, if @bvarner doesn't merge the PR, add the changes as a patchset. |
Gentlemen, it is merged.
I am in awe at all of your tenacity. :-)
…On Tue, 2019-01-08 at 09:01 -0800, humdinger wrote:
@humdingerb Can you check the other PR I made for bamkeys repo?
Looks good. It does fix the build. As alaviss said, if @bvarner
doesn't merge the PR, add the changes as a patchset.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@humdingerb Working recipe, now you may merge this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the Description you have a few too many \ escaped linebreaks. See for example all the bullet list items. Best to build the package and check the description in HaikuDepot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You didn't check your created package in HaikuDepot, did you?
The line breaks are still messed up, see https://linx.li/a8gjrqss.png
@humdingerb I didn't have enough time :P sorry. |
@humdingerb While using recipe, my haikuporter got corrupted (idk it just don't want to build recipe) and it doesnt' build any software for some reason so can you check this new recipe please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've now explicitely added a comment for every wrongly set linebreak.
@humdingerb How to break a line? I didn't understand. |
Every time your create a line break at the end of a line, the description in HaikuDepot will show that same linebreak. E.g., this will show exactly like see here:
This, however:
will show as one line because you escaped the linebreak:
So when you use " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're getting there. Last cosmetics... :)
@humdingerb New lesson learned, never use "/" for breaking into new line :) |
Something gone wrong. |
All good now. Thanks! |
silence.... |
Hmm? This PR was merged on 12 January. |
Recipe for BamKeys! I have created a PR for changes in BamKeys so check that out so that I can add remaining stuffs in recipe.
bvarner/bamkeys#1