Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe for BamKeys. #3535

Merged
merged 9 commits into from Jan 12, 2019
Merged

Conversation

arnavbhatt288
Copy link
Contributor

Recipe for BamKeys! I have created a PR for changes in BamKeys so check that out so that I can add remaining stuffs in recipe.
bvarner/bamkeys#1

haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
@arnavbhatt288
Copy link
Contributor Author

@humdingerb Done.

@arnavbhatt288
Copy link
Contributor Author

@humdingerb Can you check the other PR I made for bamkeys repo?

Copy link
Contributor

@alaviss alaviss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this recipe does not use a tagged source, please use 1.0.0_<date of chosen commit in yyyymmdd> as the version.

haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
@humdingerb
Copy link
Member

@humdingerb Can you check the other PR I made for bamkeys repo?

Looks good. It does fix the build. As alaviss said, if @bvarner doesn't merge the PR, add the changes as a patchset.

@bvarner
Copy link

bvarner commented Jan 8, 2019 via email

@arnavbhatt288
Copy link
Contributor Author

arnavbhatt288 commented Jan 9, 2019

@humdingerb Working recipe, now you may merge this PR.

Copy link
Member

@humdingerb humdingerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Description you have a few too many \ escaped linebreaks. See for example all the bullet list items. Best to build the package and check the description in HaikuDepot.

haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
Copy link
Member

@humdingerb humdingerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't check your created package in HaikuDepot, did you?
The line breaks are still messed up, see https://linx.li/a8gjrqss.png

haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
@arnavbhatt288
Copy link
Contributor Author

@humdingerb I didn't have enough time :P sorry.

@arnavbhatt288
Copy link
Contributor Author

arnavbhatt288 commented Jan 11, 2019

@humdingerb While using recipe, my haikuporter got corrupted (idk it just don't want to build recipe) and it doesnt' build any software for some reason so can you check this new recipe please?

Copy link
Member

@humdingerb humdingerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've now explicitely added a comment for every wrongly set linebreak.

haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
@arnavbhatt288
Copy link
Contributor Author

@humdingerb How to break a line? I didn't understand.

@humdingerb
Copy link
Member

@humdingerb How to break a line? I didn't understand.

Every time your create a line break at the end of a line, the description in HaikuDepot will show that same linebreak. E.g., this will show exactly like see here:

BamKeys let's you break your display up into
a grid of zones. Each zone is assigned a keyboard combination. 

This, however:

BamKeys let's you break your display up into \
a grid of zones. Each zone is assigned a keyboard combination. 

will show as one line because you escaped the linebreak:

BamKeys let's you break your display up into a grid of zones. Each zone is assigned a keyboard combination. 

So when you use "\" at the end of every line in your numbered list, all items will show up without linebreaks in a single line.

Copy link
Member

@humdingerb humdingerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting there. Last cosmetics... :)

haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
haiku-apps/bamkeys/bamkeys-1.0.0.recipe Outdated Show resolved Hide resolved
haiku-apps/bamkeys/bamkeys-1.0.0.recipe Show resolved Hide resolved
@arnavbhatt288
Copy link
Contributor Author

@humdingerb New lesson learned, never use "/" for breaking into new line :)

@arnavbhatt288
Copy link
Contributor Author

Something gone wrong.

@humdingerb humdingerb merged commit a53782f into haikuports:master Jan 12, 2019
@humdingerb
Copy link
Member

All good now. Thanks!

@arnavbhatt288 arnavbhatt288 deleted the recipe-for-bamkeys branch March 18, 2019 13:26
@arnavbhatt288
Copy link
Contributor Author

silence....

@diversys
Copy link
Member

Hmm? This PR was merged on 12 January.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants