Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vala, bump version #3679

Merged
merged 1 commit into from
Nov 30, 2019
Merged

vala, bump version #3679

merged 1 commit into from
Nov 30, 2019

Conversation

Begasus
Copy link
Contributor

@Begasus Begasus commented Mar 8, 2019

No description provided.

@Begasus
Copy link
Contributor Author

Begasus commented Mar 9, 2019

@korli could you check? If it's ok I'll remove the previous version to reduce the noice on github :)

Copy link
Contributor

@korli korli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the previous recipe? It's easier to read the differences.

@Begasus Begasus force-pushed the vala branch 2 times, most recently from 819c025 to b907a98 Compare March 10, 2019 16:12
@Begasus
Copy link
Contributor Author

Begasus commented Mar 12, 2019

Not sure if the issue on haikuporter is still in the way (haikuports/haikuporter#183) but at this moment I think the recipe is ok

@Begasus
Copy link
Contributor Author

Begasus commented Mar 23, 2019

Reverted the changes, at this moment I'm still left with "Warning: POLICY ERROR: can't find used library "libvalaccodegen.so"" when running haikuporter in strict mode
EDIT
From the Changelog for version 0.42.4 "libvaladoc: Link against private libvalaccodegen" so this is where it started, commit https://gitlab.gnome.org/GNOME/vala/commit/8d7332c4041c05ddb7165f6875ea3b1e3f94816e

@Begasus
Copy link
Contributor Author

Begasus commented Nov 29, 2019

Bumped to 0.47.1, packages build OK if you don't run it in strict mode with haikuporter, issue for that is created at haikuporter: haikuports/haikuporter#183

@korli
Copy link
Contributor

korli commented Nov 30, 2019

haikuporter normally follows the RPATH configured to check dependent libs.

@Begasus
Copy link
Contributor Author

Begasus commented Nov 30, 2019

Don't know what else I can do here, merging it would probably end up in a broken build if the buildbot runs haikuporter in strict mode

@korli
Copy link
Contributor

korli commented Nov 30, 2019

The buildbot doesn't run haikuporter in strict mode.

@Begasus
Copy link
Contributor Author

Begasus commented Nov 30, 2019

Then this should be ok as is :)

The buildbot doesn't run haikuporter in strict mode.

@korli korli merged commit 2b36e60 into haikuports:master Nov 30, 2019
@Begasus Begasus deleted the vala branch November 30, 2019 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants