WIP: cargo-c: New recipe #5534
Merged
WIP: cargo-c: New recipe #5534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haiku-bot
pushed a commit
to haiku/haiku
that referenced
this pull request
Aug 27, 2021
This translator only supports still images for now, and supports both decoding and encoding. Encoding support has been tested only with aom, rav1e doesn’t build on Haiku yet, see haikuports/haikuports#5534 for one of the missing dependencies. Change-Id: I716f4b862ed316b89b227bfed38072d72074201f Reviewed-on: https://review.haiku-os.org/c/haiku/+/3040 Reviewed-by: waddlesplash <waddlesplash@gmail.com> Reviewed-by: Jérôme Duval <jerome.duval@gmail.com> Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
|
Got a bit further (version 0.9.9) but then: |
|
Build log: Maybe @nielx could shed a light here? |
|
The issue is described here: nielx/rust#15 Two alternatives:
|
Thanks, will look at those links in a bit, now going for the Gentoo approach described here: https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-util/cargo-c/cargo-c-0.9.5.ebuild#n188 |
Not sure what the gentoo approach is, but the issue is likely that the current recipe pulls the latest dependencies, which includes the broken libgit2. Ideally during the build process you want to downgrade to libgit2-sys 0.12.24+1.3.0. The build steps before cargo build would look something like: |
|
If I read it right it's forcing the build to use the system libgit2: EDIT that didn't work ;) |
That might actually worth a try! Though I don't know how close the libgit2.a version and the rust libgit2-sys are coupled, so you might run into other linker errors. |
|
Getting there (slowly) with 0.9.8 (which is still using libgit2-sys 0.12.26+1.3.0 (so prior to 0.13.2+1.4.2 in regard to version 0.9.9)) |
|
Not to bad I think (but no recipe yet): EDIT not there yet, rav1e was build with cargo (not cargo-c), for cargo-c I guess adding support for Haiku is needed (looking into that) |
Great call! I may add that as a build dependency for Rust as well, though I am not sure if I can get it using cross-compiling. |
|
OK, so far, build libgit2 version 1.4.3, build cargo-c version 0.9.8 and had been able to build (in Terminal) rav1e version 0.5.1 |
|
Progress! :) EDIT Guess I should start pushing some things here :)
|
|
@nielx @linkmauve I've pushed my local changes here, together with the PR for libgit2 (#6974) I've been able to build rav1e as seen in the screenshot earlier, would be nice if someone could check this on 64bit (haven't got around to that yet). |
This was referenced Jun 4, 2022
Merged
|
|
|
Thanks for that @lu-zero ! for now I'm still using 0.9.8 as that doesn't involve the broken libgit2-sys as mentioned here earlier. |
|
@nielx been looking into creating a package for git2-rs, have been talking to the guys in the rust channel on IRC (very helpful!) Looking at the env output it doesn't search for .../lib/x86? (even when switching arch in Terminal) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dependency is required for building ffmpeg with rav1e support, for AV1 encoding.
I haven’t managed to finish the build nor to debug why it seemingly stops building once it reaches the
cargocrate, hence the WIP tag. It runs fine until then, but then all cores are mostly idle despite arustcprocess still existing. I let it run for close to five hours, to no avail.