Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new Scriptureguide release wich fixes ScriptureguideManager #5940

Merged
merged 1 commit into from
May 23, 2021

Conversation

Paradoxianer
Copy link
Contributor

No description provided.

@Begasus
Copy link
Contributor

Begasus commented May 23, 2021

Could you remove the previous version while bumping to this one?

@Paradoxianer
Copy link
Contributor Author

Could you remove the previous version while bumping to this one?

I can do this but may i ask why because with the former bump i didnt need to delete the old one. Just out of curiosity :)

@Begasus
Copy link
Contributor

Begasus commented May 23, 2021

For some recipes it's useful to have an older version around, for this, it fixes things that are broken in the previous version (probably overseen with the previous version bump) :)
So there wouldn't be a need to keep the previous versions around at haikuports (keeps git log smaller as we only see what's changed in the recipe)

@Begasus
Copy link
Contributor

Begasus commented May 23, 2021

You can see it in my PR for lapack here: https://github.com/haikuports/haikuports/pull/5910/files

@Begasus
Copy link
Contributor

Begasus commented May 23, 2021

Good to go?

@Paradoxianer
Copy link
Contributor Author

👍

@Begasus Begasus merged commit cadccf4 into haikuports:master May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants