Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-process/htop: update to Haiku-supported version 2.3.0 #6980

Merged
merged 1 commit into from Jan 20, 2023

Conversation

Low-power
Copy link
Contributor

The original version 2.0.2 builds, but almost completely useless on Haiku; as it didn't contain any Haiku-specific code, but uses the unsupported skeleton code, which can't be used to view system information and process list.

This change updates sys-process/htop to my customized version, which actually works and useful for Haiku.

htop-2.3.0-on-haiku-r1-beta3.png

Has been tested on Haiku R1/beta3.

@pulkomandy
Copy link
Member

Nice! Do you plan to submit your changes to the original htop developers?

@Low-power
Copy link
Contributor Author

Nice! Do you plan to submit your changes to the original htop developers?

I considered this, but since for some reasons my branch (based on the original repo at https://github.com/hishamhm/htop) has severely diverged from the current upstream branch, I would rather not try to rebase over there.

But the code itself is already released free (GNU GPL), it will be good too if someone picked up the code and submit to current upstream.

@Low-power
Copy link
Contributor Author

I just found #1655, which should be fixed by this pull request.

@waddlesplash
Copy link
Member

I think we would prefer to keep Haiku-support patches in-tree in HaikuPorts as a patchset instead of using a forked version where it is generally possible. Can that be done instead, please?

@Low-power
Copy link
Contributor Author

I think we would prefer to keep Haiku-support patches in-tree in HaikuPorts as a patchset instead of using a forked version where it is generally possible.

Well, since I finished the Haiku support in my fork in an early Haiku release first, before I discovered the haikuports, the code or patch is written for the fork and therefore would not easily applying to other version.

@Begasus
Copy link
Contributor

Begasus commented Aug 16, 2022

The original repository has been archived, any reason to keep us from merging? (PS, didn't check a 32bit build so far)

EDIT Checked out a build, seems to working fine, and mouse clicks work also.

htop-32bit

@Begasus Begasus merged commit 4eb3573 into haikuports:master Jan 20, 2023
win8linux pushed a commit to win8linux/haikuports that referenced this pull request Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants