Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutt recipe #699

Merged
merged 1 commit into from Dec 26, 2016
Merged

mutt recipe #699

merged 1 commit into from Dec 26, 2016

Conversation

@extrowerk
Copy link
Member

extrowerk commented Jul 13, 2016

For the sake of IMAP.
Sadly gmail requires SASL.

2000-2004 Edmund Grimley Evans
2006-2009 Rocco Rutte
2014-2015 Kevin J. McCarthy
"

This comment has been minimized.

Copy link
@waddlesplash

waddlesplash Jul 22, 2016

Member

Quote goes on previous line. And all the continuation COPYRIGHT lines should be indented by 1 tab.


BUILD()
{
libtoolize --force

This comment has been minimized.

Copy link
@waddlesplash

waddlesplash Jul 22, 2016

Member

Shouldn't this be --force --copy --install?

@extrowerk extrowerk force-pushed the extrowerk:mutt branch from 130e7da to 5dcc7fc Jul 23, 2016
@extrowerk extrowerk force-pushed the extrowerk:mutt branch from 5dcc7fc to a4c5af7 Aug 20, 2016
@extrowerk extrowerk changed the title WIP mutt recipe mutt recipe Aug 20, 2016
DESCRIPTION="A text-based email client for Unix-like systems. \
It was originally written by Michael Elkins in 1995 and released \
under the GNU General Public License version 2 or any later \
version.

This comment has been minimized.

Copy link
@diversys

diversys Sep 4, 2016

Member

Put it into previous line

@extrowerk extrowerk force-pushed the extrowerk:mutt branch from a4c5af7 to 7d2f684 Sep 4, 2016
PATCHES="mutt-$portVersion.patchset"

ARCHITECTURES="?x86_gcc2 x86 ?arm"
SECONDARY_ARCHITECTURES="?x86_gcc2 x86 ?arm"

This comment has been minimized.

Copy link
@fbrosson

fbrosson Sep 4, 2016

Member

I think you can drop the ?arm in SECONDARY_ARCHITECTURES.

cmd:gcc$secondaryArchSuffix
cmd:make
cmd:m4
cmd:gawk

This comment has been minimized.

Copy link
@fbrosson

fbrosson Sep 4, 2016

Member

You can drop the second cmd:gawk ;-)

lib:libiconv$secondaryArchSuffix
lib:libgpgme$secondaryArchSuffix
lib:libgpg_error$secondaryArch
lib:libgpg_error.so.0$secondaryArch

This comment has been minimized.

Copy link
@fbrosson

fbrosson Sep 4, 2016

Member

I think you should replace

    lib:libgpg_error$secondaryArch
    lib:libgpg_error.so.0$secondaryArch

by just

    lib:libgpg_error$secondaryArch

(if you don't need a specific version of the lib),
or by

    lib:libgpg_error$secondaryArch >= 0

(if you need libgpg_error.so.0.)

@extrowerk extrowerk force-pushed the extrowerk:mutt branch from 7d2f684 to 3c79eac Sep 10, 2016
cmd:bison
cmd:gawk
cmd:gcc$secondaryArchSuffix
cmd:make

This comment has been minimized.

Copy link
@fbrosson

fbrosson Oct 4, 2016

Member

You need to add a cmd:libtoolize$secondaryArchSuffix to BUILD_PREREQUIRES. The best place for it is just before cmd:make.
BTW, the cmd:gpgme_config$secondaryArchSuffix currently in BUILD_REQUIRES would be better in BUILD_PREREQUIRES, between the cmd:gcc$secondaryArchSuffix and the cmd:libtoolize$secondaryArchSuffix.

under the GNU General Public License version 2 or any later version.
The Mutt slogan is All mail clients suck. This one just sucks less."
HOMEPAGE="http://www.mutt.org"

This comment has been minimized.

Copy link
@fbrosson

fbrosson Oct 4, 2016

Member

IMHO it would be better to have

HOMEPAGE="http://www.mutt.org/"

I know most browsers hide the trailing slash when there is nothing after it, but, to be correct, a URL needs either a path or a trailing slash.
I also know that this is a detail and that some recipes are missing that trailing slash.
But I think we should have correct URLs in our recipes.
A practical reason for keeping the slash is that when wrong URLs are copy/pasted to forums that make hyperlinks with them, these hyperlinks do not always work because the wrapper that creates the hyperlinks is not able to correctly detect the end of the domain name when it is followed by a dot. I've already seen that in some places. This never happens with correct URLs ;-)

This comment has been minimized.

Copy link
@extrowerk

extrowerk Oct 22, 2016

Author Member

Fixed, thanks!

@extrowerk extrowerk force-pushed the extrowerk:mutt branch from 63f5429 to b4e5123 Oct 23, 2016
@extrowerk extrowerk force-pushed the extrowerk:mutt branch from b4e5123 to 9b24ded Dec 26, 2016
@waddlesplash waddlesplash merged commit 6661b5e into haikuports:master Dec 26, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dacianf added a commit to dacianf/haikuports that referenced this pull request Jan 9, 2017
korli added a commit to korli/haikuports that referenced this pull request Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.