mutt recipe #699
mutt recipe #699
Conversation
| 2000-2004 Edmund Grimley Evans | ||
| 2006-2009 Rocco Rutte | ||
| 2014-2015 Kevin J. McCarthy | ||
| " |
There was a problem hiding this comment.
Quote goes on previous line. And all the continuation COPYRIGHT lines should be indented by 1 tab.
| DESCRIPTION="A text-based email client for Unix-like systems. \ | ||
| It was originally written by Michael Elkins in 1995 and released \ | ||
| under the GNU General Public License version 2 or any later \ | ||
| version. |
| PATCHES="mutt-$portVersion.patchset" | ||
|
|
||
| ARCHITECTURES="?x86_gcc2 x86 ?arm" | ||
| SECONDARY_ARCHITECTURES="?x86_gcc2 x86 ?arm" |
There was a problem hiding this comment.
I think you can drop the ?arm in SECONDARY_ARCHITECTURES.
| cmd:bison | ||
| cmd:gawk | ||
| cmd:gcc$secondaryArchSuffix | ||
| cmd:make |
There was a problem hiding this comment.
You need to add a cmd:libtoolize$secondaryArchSuffix to BUILD_PREREQUIRES. The best place for it is just before cmd:make.
BTW, the cmd:gpgme_config$secondaryArchSuffix currently in BUILD_REQUIRES would be better in BUILD_PREREQUIRES, between the cmd:gcc$secondaryArchSuffix and the cmd:libtoolize$secondaryArchSuffix.
| under the GNU General Public License version 2 or any later version. | ||
|
|
||
| The Mutt slogan is All mail clients suck. This one just sucks less." | ||
| HOMEPAGE="http://www.mutt.org" |
There was a problem hiding this comment.
IMHO it would be better to have
HOMEPAGE="http://www.mutt.org/"
I know most browsers hide the trailing slash when there is nothing after it, but, to be correct, a URL needs either a path or a trailing slash.
I also know that this is a detail and that some recipes are missing that trailing slash.
But I think we should have correct URLs in our recipes.
A practical reason for keeping the slash is that when wrong URLs are copy/pasted to forums that make hyperlinks with them, these hyperlinks do not always work because the wrapper that creates the hyperlinks is not able to correctly detect the end of the domain name when it is followed by a dot. I've already seen that in some places. This never happens with correct URLs ;-)
For the sake of IMAP.
Sadly gmail requires SASL.