Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fontforge: Initial GUI support #7051

Closed
wants to merge 2 commits into from

Conversation

extrowerk
Copy link
Member

No description provided.

@waddlesplash
Copy link
Member

It should be possible to specify the GDraw backend in the recipe so we can be sure we are getting the GDK backend and not the raw X11 one.

@extrowerk
Copy link
Member Author

This looks like a normal X11 version, we should however use the gnome3 gui.

Tried to enable GDK3, unsuccessfully
@extrowerk
Copy link
Member Author

I am unable to find out how to force GDK3, sorry.

The FontForge Project"
LICENSE="GNU GPL v3
BSD (3-clause)"
REVISION="4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New version, reset revision:

- REVISION="4"
+ REVISION="1"

Comment on lines +98 to +102
-DCMAKE_PREFIX=$appsDir/FontForge \
-DCMAKE_BUILD_TYPE=Release \
-DENABLE_X11=OFF \
-DENABLE_PYTHON_SCRIPTING=OFF \
$cmakeDirArgs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion (also respect $commandBinDir)

-		-DCMAKE_PREFIX=$appsDir/FontForge \
-		-DCMAKE_BUILD_TYPE=Release \
-		-DENABLE_X11=OFF \
-		-DENABLE_PYTHON_SCRIPTING=OFF \
-		$cmakeDirArgs
+		$cmakeDirArgs
+		-DCMAKE_BUILD_TYPE=Release \
+		-DCMAKE_INSTALL_BINDIR=$commandBinDir \
+		-DENABLE_X11=OFF \
+		-DENABLE_PYTHON_SCRIPTING=OFF

mkdir $appsDir
mv $binDir/fontforge $appsDir/FontForge

rm -rf $prefix/non-packaged
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add:

+ 	rm -rf $dataDir/{applications,icons,metainfo}

Not entirely sure about metainfo :)

@extrowerk
Copy link
Member Author

It seems i am unable to find the reason why it doesn't want to use the gtk ui. Sorry.

@waddlesplash
Copy link
Member

Based on the source code -DENABLE_X11=OFF should suffice: https://github.com/fontforge/fontforge/blob/master/gdraw/CMakeLists.txt#L65

Are you sure it's really building the X11 version? You can add message(FATAL_ERROR "...") in the X11 block of that CMakeLists file to find out for sure what is being used.

@extrowerk
Copy link
Member Author

Are you sure it's really building the X11 version?

I have eyes, so yes, definetely.
Building it outside of the chroot results GTK used, in the chroot X11 version gets compiled, which looks really motif-esque.
Probably a dependency is missing from the chroot, but comparing the logs doesn't tells me whats missing.

@waddlesplash
Copy link
Member

What about editing the CMakeLists as I pointed to?

@extrowerk
Copy link
Member Author

Are you sure it's really building the X11 version?

The version built outside of HP have gtk styled ui control elements, while the one built with HP have motif-like ui, so i would say: yes, i am sure.

No idea, where the difference comes from, i have even compared the logs and stuff.


PROVIDES="
fontforge$secondaryArchSuffix = $portVersion
app:fontforge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmd:fontforge is not provided. It should probably be added back. There are use-cases for fontforge as a command line tool.

make install

mkdir $appsDir
mv $binDir/fontforge $appsDir/FontForge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be replaced with a symlink (or removed altogether) to retain the fontforge command.

devel:libpng16$secondaryArchSuffix
devel:libpython3.10$secondaryArchSuffix
devel:libreadline$secondaryArchSuffix
devel:libspiro$secondaryArchSuffix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably specify the version as >= 1 to make sure that it picks up the new version, because the old one was restored to not break the existing version of fontforge. Afterwards we can remove the old version of libspiro again.

@threedeyes
Copy link
Member

Windows decorator missing:
photo_2022-11-25_21-19-13

@waddlesplash
Copy link
Member

Any improvements under Wayland GTK, perhaps?

@Begasus Begasus mentioned this pull request Apr 1, 2023
@Begasus Begasus mentioned this pull request Sep 30, 2023
@Begasus
Copy link
Contributor

Begasus commented Oct 1, 2023

Closing as superseded by #9544 (changes here imported in the new version, although GUI still disabled).

@Begasus Begasus closed this Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

5 participants