-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
md4c: bump to version 0.4.8 #7251
Conversation
Remade the commit, as the previous recipe rename + changes made it appear as a new file instead, which I guess would complicate the review. I'd attempted to update the description text too, seemingly making it look too different for git. Should add a commit with only the description change? |
Since this doesn't build for primary architecture on 32bit maybe use $prefix/bin instead of $bindir to install the binary? |
Pushed an updated version, addressing some of your comments. Test should now ran (run them manually from the work dir, all passed). I managed to build and run the tests on 32 bits, but I did so without HaikuPorter/HaikuPorts, due to lack of space on that machine (I just copied the work dir to the 32 bit PC, setarch x86, and ran cmake+tests there). So I enabled x86 on the recipe, hoping for the best. Will address the commandBinDir part next. |
Made use "commandBinDir", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some cosmetic changes, not really required :)
It's nice to have those pointed out, so I can follow those better examples in the future! |
Built/Tested on 64 bit.