Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md4c: bump to version 0.4.8 #7251

Merged
merged 3 commits into from
Oct 9, 2022
Merged

md4c: bump to version 0.4.8 #7251

merged 3 commits into from
Oct 9, 2022

Conversation

OscarL
Copy link
Contributor

@OscarL OscarL commented Oct 4, 2022

Built/Tested on 64 bit.

@OscarL
Copy link
Contributor Author

OscarL commented Oct 4, 2022

Remade the commit, as the previous recipe rename + changes made it appear as a new file instead, which I guess would complicate the review.

I'd attempted to update the description text too, seemingly making it look too different for git. Should add a commit with only the description change?

@Begasus
Copy link
Contributor

Begasus commented Oct 8, 2022

Since this doesn't build for primary architecture on 32bit maybe use $prefix/bin instead of $bindir to install the binary?
For this you could use commandBinDir (see for some examples here), also use libVersionCompat maybe?
EDIT no test suite provided it seems, so this can be removed from the recipe. :)

@OscarL
Copy link
Contributor Author

OscarL commented Oct 8, 2022

Pushed an updated version, addressing some of your comments. Test should now ran (run them manually from the work dir, all passed).

I managed to build and run the tests on 32 bits, but I did so without HaikuPorter/HaikuPorts, due to lack of space on that machine (I just copied the work dir to the 32 bit PC, setarch x86, and ran cmake+tests there). So I enabled x86 on the recipe, hoping for the best.

Will address the commandBinDir part next.

@OscarL
Copy link
Contributor Author

OscarL commented Oct 8, 2022

Made use "commandBinDir", hp md4c --test passes without errors, and added a new commit just for the updated description (that better reflects the one from the md4c repo).

Copy link
Contributor

@Begasus Begasus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cosmetic changes, not really required :)

dev-util/md4c/md4c-0.4.8.recipe Outdated Show resolved Hide resolved
dev-util/md4c/md4c-0.4.8.recipe Outdated Show resolved Hide resolved
@OscarL
Copy link
Contributor Author

OscarL commented Oct 9, 2022

Some cosmetic changes, not really required :)

It's nice to have those pointed out, so I can follow those better examples in the future!

@Begasus Begasus merged commit 83fc1d2 into haikuports:master Oct 9, 2022
@OscarL OscarL deleted the md4c-bump branch October 9, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants