New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New recipe: diff-so-fancy #7872
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two really minor suggestions.
Thanks for bringing diff_so_fancy
up. I certainly need something like this!
git config --global core.pager \"diff-so-fancy | less --tabs=4 -RFX\" | ||
git config --global interactive.diffFilter \"diff-so-fancy --patch\"" | ||
HOMEPAGE="https://github.com/so-fancy/diff-so-fancy" | ||
COPYRIGHT="2016 So Fancy team" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
COPYRIGHT="2016 So Fancy team" | |
COPYRIGHT="2016-2022 So Fancy team" |
Just to acknowledge the date of this particular release (and so it doesn't appears to be "ancient" code).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've copied this from their license file, since this is mainly intended as a legal basis I'm not compfprtable with changing it on a whim.
COPYRIGHT="2016 So Fancy team" | ||
LICENSE="MIT" | ||
REVISION="1" | ||
SOURCE_URI="https://github.com/so-fancy/diff-so-fancy/releases/download/v$portVersion/diff-so-fancy#noarchive" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be better to download the whole release using the standard
https://github.com/so-fancy/diff-so-fancy/archive/refs/tags/v$portVersion.tar.gz
so that you can copy the README.md (and the other markdown files?) to $docDir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file downloaded and the file in the archive are not equivalent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's annoying. In theory you could add an extra SOURCE_URI to get the markdown files but I don't know if it's critical.
592fe0e
to
02d21b6
Compare
Resolved the comments and replied to two, I think this version should be good now. |
No description provided.