Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New recipe: diff-so-fancy #7872

Merged
merged 2 commits into from Feb 24, 2023
Merged

Conversation

nephele-gh
Copy link
Contributor

No description provided.

Copy link
Contributor

@OscarL OscarL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two really minor suggestions.

Thanks for bringing diff_so_fancy up. I certainly need something like this!

app-misc/diff-so-fancy/diff_so_fancy-1.4.3.recipe Outdated Show resolved Hide resolved
git config --global core.pager \"diff-so-fancy | less --tabs=4 -RFX\"
git config --global interactive.diffFilter \"diff-so-fancy --patch\""
HOMEPAGE="https://github.com/so-fancy/diff-so-fancy"
COPYRIGHT="2016 So Fancy team"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
COPYRIGHT="2016 So Fancy team"
COPYRIGHT="2016-2022 So Fancy team"

Just to acknowledge the date of this particular release (and so it doesn't appears to be "ancient" code).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've copied this from their license file, since this is mainly intended as a legal basis I'm not compfprtable with changing it on a whim.

COPYRIGHT="2016 So Fancy team"
LICENSE="MIT"
REVISION="1"
SOURCE_URI="https://github.com/so-fancy/diff-so-fancy/releases/download/v$portVersion/diff-so-fancy#noarchive"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to download the whole release using the standard

https://github.com/so-fancy/diff-so-fancy/archive/refs/tags/v$portVersion.tar.gz

so that you can copy the README.md (and the other markdown files?) to $docDir

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file downloaded and the file in the archive are not equivalent

see so-fancy/diff-so-fancy#455

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's annoying. In theory you could add an extra SOURCE_URI to get the markdown files but I don't know if it's critical.

app-misc/diff-so-fancy/diff_so_fancy-1.4.3.recipe Outdated Show resolved Hide resolved
app-misc/diff-so-fancy/diff_so_fancy-1.4.3.recipe Outdated Show resolved Hide resolved
@nephele-gh
Copy link
Contributor Author

Resolved the comments and replied to two, I think this version should be good now.

@augiedoggie augiedoggie merged commit 52de4ef into haikuports:master Feb 24, 2023
win8linux pushed a commit to win8linux/haikuports that referenced this pull request Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants