unicorn: provide Python bindings in a separate recipe. #8112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows to: - Decouple the building of the Python bindings (otherwise needs to rebuild full libunicorn.so for each build of the bindings). - Be able to provide bindings for multiple Python versions. The tiny patch is the same as one already applied upstream 3 weeks ago, so it could be dropped on next release/update. Also: - Removed static library. - Disabled building of tests.
|
In case the recipe split is not desired, here's an alternative recipe cleanup (in collaboration with @Begasus), that leaves it as a single recipe, but allows for easier changes in the supported Python version. |
|
@OscarL I don't know any recipes actually using unicorn, what's the usecase for python bindings? |
|
@korli no idea, really. Just saw them there in the original recipe, and trying to clean that part was a bit painful (due to having to run the whole recipe), so separating them seemed like a good option to me. But the alternative I've linked in a comment above also works, or guess we could drop its bindings altogether, if they're not really useful? Paging @kallisti5 :-) |
|
Closing in favor of #8641. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to:
The tiny patch is the same as one already applied upstream 3 weeks ago, so it could be dropped on next release/update.
Also: