Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created apng2gif recipe #910

Merged
merged 1 commit into from
Dec 5, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions media-gfx/apng2gif/apng2gif-1.7.recipe
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
SUMMARY="Converts APNG animations into GIF format"
DESCRIPTION="This program converts APNG animations into animated GIF format. \
It performs the reverse of gif2apng."
HOMEPAGE="http://apng2gif.sourceforge.net/"
COPYRIGHT="2009-2015 Max Stepin"
LICENSE="Zlib"
REVISION="1"
SOURCE_URI="https://downloads.sourceforge.net/apng2gif/apng2gif-$portVersion-src.zip"
CHECKSUM_SHA256="6c7b2cce851378f2fc8f6b490ce098e9cf0038aa05da7099771c8be94620e6ca"
SOURCE_DIR=""

ARCHITECTURES="x86_gcc2 x86 x86_64"

if [ "$targetArchitecture" = x86_gcc2 ]; then
LIBS="-lstdc++.r4 -lpng -lz"
else
LIBS="-lstdc++ -lpng -lz"
fi
Copy link
Member

@fbrosson fbrosson Dec 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, let's drop this block (in both apng2gif and gif2apng).
There are several reasons for this:

  • We are not using commandSuffix.
  • We are only using commandBinDir in one place, INSTALL, and we can replace $commandBinDir by $prefix/bin for this recipe on all architectures, both primary and secondary.
  • This recipe does not provide any lib, so after we drop x86_gcc2 (some time in the future) we will be able to completely drop support for secondary architectures for this recipe.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing. Was initially going that route, but wasn't sure if you were going to end up having me add it.


PROVIDES="
apng2gif = $portVersion
cmd:apng2gif = $portVersion
"
REQUIRES="
haiku
lib:libpng
lib:libz
"

BUILD_REQUIRES="
haiku_devel
devel:libpng
devel:libz
"
BUILD_PREREQUIRES="
cmd:gcc
cmd:ld
cmd:make
"

BUILD()
{
make LIBS="$LIBS"
}

INSTALL()
{
install -d -m 755 $binDir $docDir
install -t $binDir -c -m 555 -s apng2gif
install -t $docDir -c -m 444 readme.txt
}
11 changes: 6 additions & 5 deletions media-gfx/gif2apng/gif2apng-1.9.recipe
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ Usually it makes the files smaller."
HOMEPAGE="http://gif2apng.sourceforge.net/"
COPYRIGHT="2009-2013 Max Stepin"
LICENSE="Zlib"
REVISION="1"
REVISION="2"
SOURCE_URI="https://downloads.sourceforge.net/gif2apng/gif2apng-$portVersion-src.zip"
CHECKSUM_SHA256="3b21308e935d799b3ffb4a86c6e00ffa4cb9b3f72f52d58d51c66eb0574ae7d2"
SOURCE_DIR=""

ARCHITECTURES="!x86_gcc2 x86 x86_64"
SECONDARY_ARCHITECTURES="x86"
SECONDARY_ARCHITECTURES="!x86_gcc2 x86"

PROVIDES="
gif2apng$secondaryArchSuffix = $portVersion
Expand All @@ -27,8 +27,8 @@ BUILD_REQUIRES="
"
BUILD_PREREQUIRES="
cmd:gcc$secondaryArchSuffix
cmd:make
cmd:ld$secondaryArchSuffix
cmd:make
"

BUILD()
Expand All @@ -38,6 +38,7 @@ BUILD()

INSTALL()
{
mkdir -p $prefix/bin
cp gif2apng $prefix/bin
install -d -m 755 $prefix/bin $docDir
install -t $prefix/bin -c -m 555 -s gif2apng
install -t $docDir -c -m 444 readme.txt
}