Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hexvexed recipe 2 :/ #956

Merged
merged 26 commits into from Dec 25, 2016
Merged

Hexvexed recipe 2 :/ #956

merged 26 commits into from Dec 25, 2016

Conversation

punsith
Copy link
Contributor

@punsith punsith commented Dec 25, 2016

No description provided.

@punsith
Add files via upload
8810a54
@punsith
Add files via upload
440091f
@punsith
Delete hexvexed-0.0.1.recipe
516c4a8
@punsith
Add files via upload
214d338
@punsith
Update hexvexed-0.0.1(1).recipe
54f6485
@punsith
Delete hexvexed-0.0.1(1).recipe
42c4795
@punsith
Update hexvexed-0.0.1.recipe
ed76282
@punsith
Update hexvexed-0.0.1.recipe
a6248e4
@punsith
Update hexvexed-0.0.1.recipe
381bd21
@punsith
Update hexvexed-0.0.1.recipe
837f616 
changed
@punsith
Update hexvexed-0.0.1.recipe
baff570
@punsith
Update hexvexed-0.0.1.recipe
87a86e0 
Change it
@punsith
Update hexvexed-0.0.1.recipe
bfc1c77 
Updated
@punsith
Update hexvexed-0.0.1.recipe
33244ef 
updated Summary and  Decryption
@punsith
Update hexvexed-0.0.1.recipe
d8bbb74 
add install block
@punsith
Rename hexvexed-0.0.1.recipe to haiku-games/hexvexed/hexvexed-0.0.1.r…
57ec9e0 
…ecipe
@punsith
Update hexvexed-0.0.1.recipe
684051f
@punsith
Update hexvexed-0.0.1.recipe
7a72be5
@punsith
Update hexvexed-0.0.1.recipe
e779d60
@punsith
Update hexvexed-0.0.1.recipe
8af9027
@punsith
Update hexvexed-0.0.1.recipe
d59648c 
updated install block
@punsith
Update hexvexed-0.0.1.recipe
f0651a1
@punsith
Update hexvexed-0.0.1.recipe
3019898
@punsith
Update hexvexed-0.0.1.recipe
27545d7
@punsith
Update hexvexed-0.0.1.recipe
e742ce3
@punsith punsith closed this Dec 25, 2016
@punsith punsith deleted the Hexvexed-2 branch December 25, 2016 16:58
fbrosson
fbrosson reviewed Dec 25, 2016
View reviewed changes
Copy link
Member

@fbrosson fbrosson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @punsith for the delay.
There was a tiny error in your recipe: the checksum was not correct.
It had 35e0904d91f15fefe801cdb7b9f9bdf4dc925de69f5b8818bec24cc4c22dc6d7 while the correct chscksum for the revision you took is 6b42c3dd2dd6b26a2a698fd98dbdd5d022d6491e5a894a329ac10766790b82df.

Well, since there is a new commit, would you mind updating to it?
Here are a few changes, if you can forgive me and the other mentors for the delay we took to reply.
Many thanks!

BTW, I just realized that HexVexed only builds on x86_gcc2... but crashes when launched.
(Well it crashes on my system.)

haiku-games/hexvexed/hexvexed-0.0.1.recipe
COPYRIGHT="2009-2016 Scott McCreary"
LICENSE="MIT"
REVISION="1"
commit="68437a22c788"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please replace

commit="68437a22c788"

by

commit="f9cd2a7b1ba1"

haiku-games/hexvexed/hexvexed-0.0.1.recipe
REVISION="1"
commit="68437a22c788"
SOURCE_URI="https://bitbucket.org/scottmc/hexvexed/get/$commit.zip"
CHECKSUM_SHA256="35e0904d91f15fefe801cdb7b9f9bdf4dc925de69f5b8818bec24cc4c22dc6d7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please replace

SOURCE_URI="https://bitbucket.org/scottmc/hexvexed/get/$commit.zip"
CHECKSUM_SHA256="35e0904d91f15fefe801cdb7b9f9bdf4dc925de69f5b8818bec24cc4c22dc6d7"

by

SOURCE_URI="https://bitbucket.org/scottmc/hexvexed/get/$commit.tar.bz2"
CHECKSUM_SHA256="72b1a5e2d3d91a453b289948edfcb437d8c2e7f8698255a109f57e6aad6a4138"

haiku-games/hexvexed/hexvexed-0.0.1.recipe
CHECKSUM_SHA256="35e0904d91f15fefe801cdb7b9f9bdf4dc925de69f5b8818bec24cc4c22dc6d7"
SOURCE_DIR="scottmc-hexvexed-$commit"

ARCHITECTURES="x86_gcc2 x86 ?x86_64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please replace

ARCHITECTURES="x86_gcc2 x86 ?x86_64"

by

ARCHITECTURES="?x86_gcc2 !x86 !x86_64"

@punsith
Copy link
Contributor Author

punsith commented Dec 25, 2016

@fbrosson sure I will change it :D

@punsith punsith restored the Hexvexed-2 branch December 25, 2016 18:29
@fbrosson
Copy link
Member

fbrosson commented Dec 25, 2016 •
edited

Cool, thanks @punsith!

BTW, I cannot reopen this PR. The "Reopen and comment" button is disabled.
Can you try to reopen it yourself?
EDIT: The "Reopen and comment" button became active! 🎉

@fbrosson fbrosson reopened this Dec 25, 2016
fbrosson
fbrosson approved these changes Dec 25, 2016
View reviewed changes
Copy link
Member

@fbrosson fbrosson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @punsith for your PR!

@fbrosson
Copy link
Member

@scottmc, shall we merge the recipe with the current tags (that @punsith has kindly added on my request) and that say that the recipe does not build on x86 and x86_64 and that it is untested on x86_gcc2?
In other words, did someone manage to launch HexVexed on x86_gcc2 without crashing it?

@waddlesplash waddlesplash merged commit c5a45f5 into haikuports:master Dec 25, 2016
@waddlesplash waddlesplash mentioned this pull request Dec 25, 2016
Closed
@punsith
Copy link
Contributor Author

punsith commented Dec 25, 2016

@fbrosson you are welcome

korli pushed a commit to korli/haikuports that referenced this pull request Jan 26, 2017
@punsith @korli
Hexvexed recipe (haikuports#956)
e472768
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbrosson fbrosson fbrosson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@punsith @fbrosson @waddlesplash