i dont think that does anything

hail-is · Oct 16, 2023 · ac19f23 · ac19f23
1 parent 0d97967
commit ac19f23
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/hail/src/main/scala/is/hail/expr/ir/Parser.scala b/hail/src/main/scala/is/hail/expr/ir/Parser.scala
@@ -847,7 +847,7 @@ object IRParser {
         val typ = type_expr(it)
         val encodedValue = Base64.getDecoder.decode(string_literal(it))
         val codec = TypedCodecSpec(
-          EType.defaultFromPType(PType.canonical(typ)),
+          EType.fromTypeAllOptional(typ),
           typ,
           BufferSpec.unblockedUncompressed
         )

diff --git a/hail/src/main/scala/is/hail/types/encoded/ENDArrayColumnMajor.scala b/hail/src/main/scala/is/hail/types/encoded/ENDArrayColumnMajor.scala
@@ -63,7 +63,7 @@ case class ENDArrayColumnMajor(elementType: EType, nDims: Int, required: Boolean
   def _decodedSType(requestedType: Type): SType = {
     val requestedTNDArray = requestedType.asInstanceOf[TNDArray]
     val elementPType = elementType.decodedPType(requestedTNDArray.elementType)
-    SNDArrayPointer(PCanonicalNDArray(elementPType, requestedTNDArray.nDims, false))
+    SNDArrayPointer(PCanonicalNDArray(elementPType, requestedTNDArray.nDims, required))
   }
 
   override def setRequired(required: Boolean): EType = ENDArrayColumnMajor(elementType, nDims, required)