Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEP output going to stderr #8146

Closed
danking opened this issue Feb 24, 2020 · 5 comments · Fixed by #8150
Closed

VEP output going to stderr #8146

danking opened this issue Feb 24, 2020 · 5 comments · Fixed by #8150
Assignees

Comments

@danking
Copy link
Collaborator

danking commented Feb 24, 2020

See discuss post: https://discuss.hail.is/t/redirect-or-find-vep-or-other-error-output-from-a-hail-pipeline/1308/9?u=danking

It looks like Hail isn’t capturing all the VEP output. Can someone look into this? Probably the way we’re executing external commands needs to also capture stderr and print it.

Assigning Tim for delegation.

@danking danking assigned tpoterba and chrisvittal and unassigned tpoterba Feb 24, 2020
@danking
Copy link
Collaborator Author

danking commented Feb 24, 2020

Tim is on vacation. dice says chris.

@chrisvittal
Copy link
Collaborator

Ok. What's going on here is like a proper pipe, we're consuming vep's standard error on a background thread and outputting it to System.err , then in the failure path, we're attempting to consume it again. This goes poorly. Fix incoming.

@danking
Copy link
Collaborator Author

danking commented Feb 25, 2020

thank you much Chris!

@konradjk
Copy link
Collaborator

FWIW it does go into the container logs which is how I've always pulled out the true error, but I'm not sure how to get that on every system. For future reference, there's an even more pernicious issue, which is that when running VEP with -o STDOUT it actually suppresses certain error messages too - and there's not much you can do about that unless you actually go in and run VEP manually without that, in the environment that hail uses.

@chrisvittal
Copy link
Collaborator

This change will make it so that it no longer goes to the container logs, and instead will be placed in the exception message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants