Repository navigation
CHANGELOG Allow subnet to be passed through to gcloud in hailctl - #13129
Merged
Merged
Conversation
tlangs
changed the title
daniel-goldstein
approved these changes
Jun 1, 2023
daniel-goldstein
left a comment
daniel-goldstein
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution @tlangs!
Author
|
I don't believe I have access to look at the test failures. If you let me know what failed, I'll do my best to fix it! |
Contributor
|
@tlangs Nothing on your end, we've had some CI instability lately that's causing some unrelated failures. I'll make sure to retest this once that's fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hailctlallows the user to define anetworkfor a new dataproc cluster, but not asubnet. Thenetworkflag ingcloudonly works forautoandlegacyproject networks. If a Google Project has a custom network, thesubnetmust be supplied manually.This PR adds that functionality to
hailctl. Its a very simple passthrough, so not much effort was required.