[query] add eigh method#13166
Merged
Merged
Conversation
ehigham
previously requested changes
Jun 20, 2023
ehigham
left a comment
ehigham
left a comment
Member
There was a problem hiding this comment.
Nice and clean - was pretty easy to understand without diving into the details of dsyevr. I'll assume that's wired up correctly.
Slight sticky point with docstring, otherwise comments for my reference/preference
ehigham
approved these changes
Jun 21, 2023
ehigham
left a comment
ehigham
left a comment
Member
There was a problem hiding this comment.
Looks great, apologies for the delayed review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an
eighndarray method, for finding eigenvalues of symmetric matrices ("h" is for Hermitian, the complex analogue of symmetric). This just dispatches to an LAPACK method. The interface is compatible with scipy.