Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] add eigh method #13166

Merged
merged 3 commits into from Jun 22, 2023
Merged

[query] add eigh method #13166

merged 3 commits into from Jun 22, 2023

Conversation

patrick-schultz
Copy link
Collaborator

@patrick-schultz patrick-schultz commented Jun 9, 2023

Add an eigh ndarray method, for finding eigenvalues of symmetric matrices ("h" is for Hermitian, the complex analogue of symmetric). This just dispatches to an LAPACK method. The interface is compatible with scipy.

Copy link
Collaborator

@ehigham ehigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean - was pretty easy to understand without diving into the details of dsyevr. I'll assume that's wired up correctly.
Slight sticky point with docstring, otherwise comments for my reference/preference

Copy link
Collaborator

@ehigham ehigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, apologies for the delayed review.

@danking danking merged commit f653260 into hail-is:main Jun 22, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants