[fs] Fix globbing in the scala blob storage FS #13173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-goldstein
force-pushed
the
fix-scala-globbing
branch
3 times, most recently
from
4f87645
to
db15581
Compare
daniel-goldstein
force-pushed
the
fix-scala-globbing
branch
from
db15581
to
d942f30
Compare
patrick-schultz
previously requested changes
Jun 13, 2023
| } | ||
| parseHttpsUrl(filename) | ||
| .orElse(parseHailAzUrl(filename)) | ||
| .getOrElse(throw new IllegalArgumentException("ABS URI must be of the form https://<ACCOUNT>.blob.core.windows.net/<CONTAINER>/<PATH>")) |
There was a problem hiding this comment.
Error reporting has gotten a little worse. Before we gave specialized errors depending on the scheme. Maybe it's worthwhile to still match the scheme first, then match the rest with the appropriate regex?
patrick-schultz
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using URL parsing for object storage URIs has proven problematic as they don't really have the same syntax. In particular, Java URI truncates the path at
?and assigns the rest to a query string field (as it should), but?is a valid character in a blob storage object and is used as a glob pattern. We were forgetting to look at theURI.queryfield to assemble the full object name and therefore broke globbing. I added a few tests specifically that used single-character match pattern (?) and got rid ofURIin favor of a regex to get ahead of any other potential footguns.