Fix #13045 - Comparison of Structs and Struct Exprs #13226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehigham
commented
Jul 6, 2023
Comment on lines
+97
to
+99
| return self._fields == other._fields \ | ||
| if isinstance(other, Struct) \ | ||
| else NotImplemented |
There was a problem hiding this comment.
as you wish |
patrick-schultz
requested changes
Jul 7, 2023
hail/python/hail/expr/functions.py
Outdated
Comment on lines
241
to
244
| wrapper['has_free_vars'] = ( | ||
| x._ir.free_vars.__len__() > 0 or | ||
| x._ir.free_agg_vars.__len__() > 0 or | ||
| x._ir.free_scan_vars.__len__() > 0 |
There was a problem hiding this comment.
This needs to be a |=, no?
There was a problem hiding this comment.
no difference for positive integers?
There was a problem hiding this comment.
I mean wrapper['has_free_vars'] |= .... Otherwise, if there are multiple nested expressions, and the last has no free variables but others do, we will only remember the False from the last.
There was a problem hiding this comment.
Ah yes. Mutation. I forgot this can get called more than once
patrick-schultz
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RR: #13045
RR: #13046
Support symmetric comparison of structs and struct expressions.
Provide better error messages when attempting to construct literals from expressions with free variables.