Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] MT.tail should prefer n_rows to n. #13508

Merged
merged 4 commits into from Sep 6, 2023
Merged

Conversation

danking
Copy link
Collaborator

@danking danking commented Aug 28, 2023

CHANGELOG: The n parameter of MatrixTable.tail is deprecated in favor of a new n_rows parameter.

MT.head already does this.

CHANGELOG: The `n` parameter of `MatrixTable.tail` is deprecated in favor of a new `n_rows` parameter.

MT.head already does this.
Copy link
Collaborator

@patrick-schultz patrick-schultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should give a deprecation warning when n is used

@danking danking dismissed patrick-schultz’s stale review August 31, 2023 22:29

I also added it to head.

@danking
Copy link
Collaborator Author

danking commented Sep 6, 2023

bump

@danking danking merged commit e0bf6e6 into hail-is:main Sep 6, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants