New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[batch] Allow hailgenetics/vep images to be public #13565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. We need a new service account without GAR access.
The publicly available images are now the same as the HAIL_GENETICS_IMAGES. Let's change this to explicitly copy over all those images as publicly available ones.
Can you be more specific on what you want the fix to be? Is there an alternate short-term fix here? What is wrong with this change? |
The images are already in our artifact registry. |
@@ -9,5 +9,7 @@ def publicly_available_images(docker_prefix: str) -> List[str]: | |||
'hailtop', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the things that we copy over from hail genetics should be public, that's why we copy them over, so let's make that explicit in the code:
from hailtop.batch.hail_genetics_images import HAIL_GENETICS_IMAGES
def publicly_available_images(docker_prefix: str) -> List[str]:
return [docker_prefix + '/' + image_name for image_name in HAIL_GENETICS_IMAGES]
removing high priority as I need to fix dataproc first. |
No description provided.