[fs] consistent use of the term FileListEntry #13594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danking
commented
Sep 8, 2023
|
To be abundantly clear: this is strictly a rename. Originally I had some changes in Python, but I've backed them out. |
danking
force-pushed
the
fix-terminology-in-hail-and-hailtop-fses
branch
from
bf22224
to
7356ca7
Compare
In our asyncio FSes, we use the term FileListEntry for the package of information you receive from a cloud object store list operation. We reserve the term FileStatus for the metadata you get about a blob without a list operation. A major difference is that FLEs know if they refer to files or folders. In contrast, a FileStatus knows that it is a file *but does not know if a directory with the same name exists*.
danking
force-pushed
the
fix-terminology-in-hail-and-hailtop-fses
branch
from
7356ca7
to
a7d065e
Compare
daniel-goldstein
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our asyncio FSes, we use the term FileListEntry for the package of information you receive from a cloud object store list operation. We reserve the term FileStatus for the metadata you get about a blob without a list operation. A major difference is that FLEs know if they refer to files or folders. In contrast, a FileStatus knows that it is a file but does not know if a directory with the same name exists.