Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[query] Better error messages for unsupported types in export_vcf #13682

Merged
merged 1 commit into from Sep 22, 2023
Merged

[query] Better error messages for unsupported types in export_vcf #13682

merged 1 commit into from Sep 22, 2023

Conversation

chrisvittal
Copy link
Collaborator

No description provided.

danking
danking previously requested changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@danking danking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great but let's add a couple python tests asserting the error message is better.

hail/src/main/scala/is/hail/io/vcf/ExportVCF.scala Outdated
}
}
if (!invalid.isEmpty) {
fatal(invalid.mkString("\n"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvement!

@danking danking merged commit 0a76edd into hail-is:main Sep 22, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danking danking danking approved these changes

Assignees

@danking danking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chrisvittal @danking