[query] Better error messages for unsupported types in export_vcf - #13682
Merged
Conversation
danking
previously requested changes
Sep 22, 2023
danking
left a comment
danking
left a comment
Contributor
There was a problem hiding this comment.
This looks great but let's add a couple python tests asserting the error message is better.
| } | ||
| } | ||
| if (!invalid.isEmpty) { | ||
| fatal(invalid.mkString("\n")) |
chrisvittal
force-pushed
the
impex/export-vcf-better-errors
branch
from
September 22, 2023 17:54
d863ff5 to
194b185
Compare
danking
approved these changes
Sep 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.