-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[query] Update ReferenceGenome docs #13924
Merged
danking
merged 3 commits into
hail-is:main
from
chrisvittal:query/update-reference-genome-docs
Oct 30, 2023
Merged
[query] Update ReferenceGenome docs #13924
danking
merged 3 commits into
hail-is:main
from
chrisvittal:query/update-reference-genome-docs
Oct 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a section on managing the default reference using the `default_reference` method.
Next part of #13856 |
danking
previously requested changes
Oct 26, 2023
------------------ | ||
Hail allows setting a default reference so that the ``reference_genome`` | ||
argument of :func:`~hail.import_vcf` does not need to be used constantly. | ||
It is a current limitation of hail that a custom reference genome cannot be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalize hail when used as a noun in English text.
It is a current limitation of hail that a custom reference genome cannot be | ||
used as the ``default_reference`` argument of :func:`~hail.init`. In order | ||
to set a custom reference genome as default, pass the reference as an argument | ||
to :func:`~hail.default_reference` after initializing hail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
chrisvittal
force-pushed
the
query/update-reference-genome-docs
branch
from
October 27, 2023 21:03
1a5dcb3
to
e41b828
Compare
danking
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a section on managing the default reference using the
default_reference
method.