[query] Deprecate default_reference parameter to hl.init #13987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG: Deprecate default_reference parameter to hl.init, users should use `default_reference` with an argument to set new default references usually shortly after init.
danking
previously requested changes
Nov 9, 2023
| @@ -141,7 +141,7 @@ def default_reference(self) -> ReferenceGenome: | |||
| return self._default_ref | |||
|
|
|||
| @default_reference.setter | |||
| def set_default_reference(self, value): | |||
| def default_reference(self, value): | |||
There was a problem hiding this comment.
Huh, I would not have expected this to work (two methods with the same name), but indeed it works.
In [1]: class Foo:
...: def __init__(self):
...: self._x = 3
...: @property
...: def x(self):
...: return self._x
...: @x.setter
...: def x(self, new_x):
...: self._x = new_x
...:
In [2]: x = Foo()
In [3]: x.x = 3
In [4]: x.x
Out[4]: 3
In [5]: x.x = 10
In [6]: x.x
Out[6]: 10There was a problem hiding this comment.
In fact, they have to have the same name. It doesn't work otherwise.
|
Can you also put in a "Fixes #...." line to the description? |
Co-authored-by: Dan King <daniel.zidan.king@gmail.com>
danking
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG: Deprecate default_reference parameter to hl.init, users should use
default_referencewith an argument to set new default references usually shortly after init.Resolves #13856