[query] support importing empty JSON objects - #14202
Merged
Merged
Conversation
@patrick-schultz I'm not sure if this makes sense or not, but I observed it while working on something else. It seems weird but acceptable to import an empty dictionary as any struct. Does this seem reasonable to you? How have we avoided this bug for so long? I'm not familiar enough with this code to know how to simply reproduce the bug and add a corresponding test. Thoughts?
patrick-schultz
approved these changes
Jan 29, 2024
patrick-schultz
left a comment
patrick-schultz
left a comment
Member
There was a problem hiding this comment.
Looks right to me, good catch
patrick-schultz
previously requested changes
Jan 29, 2024
patrick-schultz
left a comment
patrick-schultz
left a comment
Member
There was a problem hiding this comment.
Ah right, tests. Looks like this is tested here. We're not testing cases where some fields aren't in the json object, only setting some to null.
patrick-schultz
approved these changes
Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@patrick-schultz I'm not sure if this makes sense or not, but I observed it while working on something else. It seems weird but acceptable to import an empty dictionary as any struct. Does this seem reasonable to you? How have we avoided this bug for so long?
I'm not familiar enough with this code to know how to simply reproduce the bug and add a corresponding test. Thoughts?