[compiler] refactor types in bindings #14517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @patrick-schultz and the rest of your teammates on |
patrick-schultz
changed the title
patrick-schultz
force-pushed
the
ps-05-02-refactor_types_in_bindings
branch
3 times, most recently
from
0c0462a
to
c78664c
Compare
patrick-schultz
force-pushed
the
ps-05-02-refactor_types_in_bindings
branch
from
c78664c
to
e1b0d89
Compare
|
Note that this is passing tests, except for the timeout issue we're seeing everywhere. |
ehigham
approved these changes
May 13, 2024
patrick-schultz
force-pushed
the
ps-05-02-refactor_types_in_bindings
branch
from
e1b0d89
to
ad60202
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly tweak the
Bindingsclass to store a single array of (name, type) pairs, with the various environments referring back to that array. This simplifies passes that want to create a single mutable state for each binding, even those that are bound in multiple environments (e.g. eval and agg).