[qob] Always send the git revision from the python service backend instead of jar_url #14541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-goldstein
force-pushed
the
remove-jar-url-config
branch
from
f1e2ecb
to
631839a
Compare
ehigham
reviewed
May 29, 2024
| @@ -359,6 +323,10 @@ def debug_info(self) -> Dict[str, Any]: | |||
| def fs(self) -> FS: | |||
| return self._sync_fs | |||
|
|
|||
| @property | |||
| def jar_spec(self) -> dict: | |||
| return {'type': 'git_revision', 'value': revision()} | |||
There was a problem hiding this comment.
To be clear, we need to make upload-for-qob on our branches to use qob?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of doing anything fancy with custom JAR urls, the hail python client always just sends its git revision for QoB jobs. When the batch front end receives the request, it resolves that git revision to either a production JAR or a dev JAR under a
/dev/directory.Resolves #14539