Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in TableLeftJoinRightDistinct related to RVD physical key #5295

Merged
merged 1 commit into from Feb 8, 2019

Conversation

Projects
None yet
3 participants
@tpoterba
Copy link
Collaborator

commented Feb 8, 2019

Fixes #5289

@tpoterba tpoterba added the prio:high label Feb 8, 2019

@@ -642,10 +642,12 @@ case class TableLeftJoinRightDistinct(left: TableIR, right: TableIR, root: Strin
val leftValue = left.execute(hc)
val rightValue = right.execute(hc)

val joinKey = left.typ.key.length
assert(joinKey == right.typ.key.length)

This comment has been minimized.

Copy link
@chrisvittal

chrisvittal Feb 8, 2019

Collaborator

If we're going to require equality here, shouldn't we just require equality in the class in general?

This comment has been minimized.

Copy link
@tpoterba

tpoterba Feb 8, 2019

Author Collaborator

ah, this is wrong. pushing up a fix.

@tpoterba tpoterba force-pushed the tpoterba:fix-left-join-right-distinct-pkey branch from 8a4c918 to 0da968d Feb 8, 2019

@chrisvittal
Copy link
Collaborator

left a comment

Looks good now.

@danking danking merged commit 4bd62d0 into hail-is:master Feb 8, 2019

1 check passed

hail-ci-0-1 successful build
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.