Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in TableLeftJoinRightDistinct related to RVD physical key #5295

Merged
merged 1 commit into from Feb 8, 2019

Conversation

tpoterba
Copy link
Contributor

@tpoterba tpoterba commented Feb 8, 2019

Fixes #5289

@@ -642,10 +642,12 @@ case class TableLeftJoinRightDistinct(left: TableIR, right: TableIR, root: Strin
val leftValue = left.execute(hc)
val rightValue = right.execute(hc)

val joinKey = left.typ.key.length
assert(joinKey == right.typ.key.length)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to require equality here, shouldn't we just require equality in the class in general?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, this is wrong. pushing up a fix.

@tpoterba tpoterba force-pushed the fix-left-join-right-distinct-pkey branch from 8a4c918 to 0da968d Compare February 8, 2019 18:39
Copy link
Collaborator

@chrisvittal chrisvittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants