Fix bug in TableLeftJoinRightDistinct related to RVD physical key #5295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisvittal
reviewed
Feb 8, 2019
| @@ -642,10 +642,12 @@ case class TableLeftJoinRightDistinct(left: TableIR, right: TableIR, root: Strin | |||
| val leftValue = left.execute(hc) | |||
| val rightValue = right.execute(hc) | |||
|
|
|||
| val joinKey = left.typ.key.length | |||
| assert(joinKey == right.typ.key.length) | |||
There was a problem hiding this comment.
If we're going to require equality here, shouldn't we just require equality in the class in general?
There was a problem hiding this comment.
ah, this is wrong. pushing up a fix.
tpoterba
force-pushed
the
fix-left-join-right-distinct-pkey
branch
from
8a4c918
to
0da968d
Compare
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5289