Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addSequence not in JVM #5306

Closed
konradjk opened this issue Feb 11, 2019 · 3 comments · Fixed by #5308
Closed

addSequence not in JVM #5306

konradjk opened this issue Feb 11, 2019 · 3 comments · Fixed by #5308
Assignees
@jigold

Comments

@konradjk
Copy link
Collaborator

Easy-peasy to reproduce:

rg = hl.get_reference('GRCh38')
rg.add_sequence('gs://hail-common/references/Homo_sapiens_assembly38.fasta.gz',
                'gs://hail-common/references/Homo_sapiens_assembly38.fasta.fai')

throws:

Py4JError: is.hail.variant.ReferenceGenome.addSequence does not exist in the JVM
@tpoterba
Copy link
Contributor

this is before initialization?

@konradjk
Copy link
Collaborator Author

like hl.init? no, after

@tpoterba
Copy link
Contributor

ah, it's just totally broken.

tpoterba added a commit to tpoterba/hail that referenced this issue Feb 11, 2019
@tpoterba
Fix add_sequence
65b3358 
fixes hail-is#5306
@tpoterba tpoterba mentioned this issue Feb 11, 2019
Merged
danking pushed a commit that referenced this issue Feb 14, 2019
@tpoterba @danking
Fix add_sequence (#5308)
733417d 
* Fix add_sequence

fixes #5306

* Add test

* Fix

* liftover uses scala object
tpoterba added a commit to tpoterba/hail that referenced this issue Feb 15, 2019
@tpoterba
Fix add_sequence (hail-is#5308)
2b0dd1b 
* Fix add_sequence

fixes hail-is#5306

* Add test

* Fix

* liftover uses scala object
This was referenced Apr 29, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jigold jigold

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix add_sequence tpoterba/hail
3 participants
@konradjk @jigold @tpoterba