Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Add ArrayExpression.index #5793

Merged
merged 2 commits into from
Apr 5, 2019
Merged

[feature] Add ArrayExpression.index #5793

merged 2 commits into from
Apr 5, 2019

Conversation

tpoterba
Copy link
Contributor

@tpoterba tpoterba commented Apr 5, 2019

Fixes #5701

@konradjk
Copy link
Collaborator

konradjk commented Apr 5, 2019

Lgtm. Curious: why range and not zip with index and find?

@tpoterba
Copy link
Contributor Author

tpoterba commented Apr 5, 2019

This will generate better IR, I think.

@konradjk
Copy link
Collaborator

konradjk commented Apr 5, 2019

Fair enough. Will neither of them short circuit if it finds it?

@tpoterba
Copy link
Contributor Author

tpoterba commented Apr 5, 2019

no, neither will short-circuit. We need recursive functions in the IR to do that

@danking danking merged commit dcde2ae into hail-is:master Apr 5, 2019
@tpoterba tpoterba mentioned this pull request Apr 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradjk konradjk konradjk approved these changes

Assignees

@konradjk konradjk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tpoterba @konradjk @danking