Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add `unify` option to `Table.union` #5858

Merged
merged 2 commits into from Apr 11, 2019

Conversation

Projects
None yet
3 participants
@tpoterba
Copy link
Collaborator

commented Apr 10, 2019

Fixes #5854

@tpoterba

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 10, 2019

Fixes #5854

else:
discovered[field] = {i: ht[field]}
all_fields = [{} for _ in all_tables]
for field, ts in discovered.items():

This comment has been minimized.

Copy link
@konradjk

konradjk Apr 10, 2019

Collaborator

Can this be field_name, expr_dict maybe? I guess it's a dict of index -> expr, but it's a little tough to figure out what's what.

all_tables = [self]
all_tables.extend(tables)

if unify and not len(set(t.row_value.dtype for t in all_tables)) == 1:

This comment has been minimized.

Copy link
@konradjk

konradjk Apr 10, 2019

Collaborator

t -> ht?

@tpoterba

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 11, 2019

good suggestions, implemented.

@danking danking merged commit 49f8a6c into hail-is:master Apr 11, 2019

1 check passed

hail-ci-0-1 successful build
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.