Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add unify option to Table.union #5858

Merged
merged 2 commits into from
Apr 11, 2019

Conversation

tpoterba
Copy link
Contributor

@tpoterba tpoterba commented Apr 10, 2019

Fixes #5854

@tpoterba
Copy link
Contributor Author

Fixes #5854

else:
discovered[field] = {i: ht[field]}
all_fields = [{} for _ in all_tables]
for field, ts in discovered.items():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be field_name, expr_dict maybe? I guess it's a dict of index -> expr, but it's a little tough to figure out what's what.

all_tables = [self]
all_tables.extend(tables)

if unify and not len(set(t.row_value.dtype for t in all_tables)) == 1:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t -> ht?

@tpoterba
Copy link
Contributor Author

good suggestions, implemented.

@danking danking merged commit 49f8a6c into hail-is:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants