Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add unify option to Table.union #5858

Merged
merged 2 commits into from Apr 11, 2019

Conversation

@tpoterba
Copy link
Collaborator

@tpoterba tpoterba commented Apr 10, 2019

Fixes #5854

@tpoterba
Copy link
Collaborator Author

@tpoterba tpoterba commented Apr 10, 2019

Fixes #5854

else:
discovered[field] = {i: ht[field]}
all_fields = [{} for _ in all_tables]
for field, ts in discovered.items():
Copy link
Collaborator

@konradjk konradjk Apr 10, 2019

Can this be field_name, expr_dict maybe? I guess it's a dict of index -> expr, but it's a little tough to figure out what's what.

all_tables = [self]
all_tables.extend(tables)

if unify and not len(set(t.row_value.dtype for t in all_tables)) == 1:
Copy link
Collaborator

@konradjk konradjk Apr 10, 2019

t -> ht?

@tpoterba
Copy link
Collaborator Author

@tpoterba tpoterba commented Apr 11, 2019

good suggestions, implemented.

@danking danking merged commit 49f8a6c into hail-is:master Apr 11, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants