[hail] Add interval reduction and intersection functions #6073
Conversation
There was a problem hiding this comment.
I think RVDPartitioner already has all this functionality. RVDPartitioner is maybe a bad name for that class, it's really the place for methods manipulating and creating ordered lists of disjoint intervals. The allowedOverlap stuff is a bit confusing; it might be worth adding some convenience methods for the simple case of length 1 keys.
| @@ -226,4 +226,52 @@ object Interval { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| def sortAndReduce(xs: Array[Interval], o: ExtendedOrdering): Array[Interval] = { | |||
There was a problem hiding this comment.
This looks equivalent to RVDPartitioner.union(ktype, xs, allowedOverlap = ktype.size)
| } | ||
|
|
||
| // assumes that both `x1` and `x2` are sorted and fully reduced. | ||
| def intersection(x1: Array[Interval], x2: Array[Interval], o: ExtendedOrdering): Array[Interval] = { |
There was a problem hiding this comment.
I think this duplicates RVDPartitioner.intersect.
|
Huh, you're totally right. I was surprised I couldn't find these methods. RVDPartitioner only works with structs, though. I'll change RVDPartitioner to call these methods. |
|
The RVDPartitioner union function contains coarsening logic, so I'm not going to abstract that one right now. |
tpoterba
force-pushed
the
interval-functions
branch
from
d9af618
to
539adc7
Compare
I want to use this in #5979