Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior of entry_float_type flag in import_vcf #6378

Merged
merged 2 commits into from Jun 19, 2019

Conversation

@tmwong2003
Copy link
Contributor

@tmwong2003 tmwong2003 commented Jun 18, 2019

This PR fixes an issue in which the entry_float_type flag in import_vcf affects all floating-point fields in a VCF, including fields defined in INFO headers. We should have restricted it to affect only fields defined in FORMAT headers.

This is a rehash of #6262 due to some forked repo damage on our end.

Copy link
Collaborator

@tpoterba tpoterba left a comment

Looks good, sorry for the hassle getting this in!

@danking danking merged commit 8903fdc into hail-is:master Jun 19, 2019
1 check passed
@tmwong2003
Copy link
Contributor Author

@tmwong2003 tmwong2003 commented Jun 19, 2019

Looks good, sorry for the hassle getting this in!

Thanks - no worries, I think we called git rebase one too many times on our side and got what we deserved...

@tmwong2003 tmwong2003 deleted the tmwong2003/fix-entry-float-type branch Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants