Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] Publicize and document Table.multi_way_zip_join #6488

Merged
merged 1 commit into from Jul 1, 2019

Conversation

@chrisvittal
Copy link
Collaborator

commented Jun 26, 2019

It remains experimental.

@chrisvittal chrisvittal force-pushed the chrisvittal:stablize-mwzj branch from 49f2094 to ab6f91a Jun 26, 2019

@@ -3212,7 +3212,40 @@ def _unlocalize_entries(self, entries_field_name, cols_field_name, col_key) -> '

@staticmethod
@typecheck(tables=sequenceof(table_type), data_field_name=str, global_field_name=str)
def _multi_way_zip_join(tables, data_field_name, global_field_name) -> 'Table':
def multi_way_zip_join(tables, data_field_name, global_field_name) -> 'Table':

This comment has been minimized.

Copy link
@chrisvittal

chrisvittal Jun 27, 2019

Author Collaborator

I don't believe the behaviour of this will change in a backwards incompatible way. The only stabilization question that I think is unresolved is do we want these parameters to have default values?

This comment has been minimized.

Copy link
@patrick-schultz

patrick-schultz Jun 28, 2019

Collaborator

Adding a default value is backwards compatible, so we can punt on that for now. But I also don't see any problem with just picking something reasonable like "row_fields" and "global_fields". I'm fine with either option, and ready to approve once you decide.

This comment has been minimized.

Copy link
@chrisvittal

chrisvittal Jun 29, 2019

Author Collaborator

leave them off for now then.

@danking danking merged commit de6aab9 into hail-is:master Jul 1, 2019

1 check passed

ci-test success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.