Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] Publicize and document Table.multi_way_zip_join #6488

Merged
merged 1 commit into from Jul 1, 2019

Conversation

@chrisvittal
Copy link
Collaborator

@chrisvittal chrisvittal commented Jun 26, 2019

It remains experimental.

@@ -3212,7 +3212,40 @@ def _unlocalize_entries(self, entries_field_name, cols_field_name, col_key) -> '

@staticmethod
@typecheck(tables=sequenceof(table_type), data_field_name=str, global_field_name=str)
def _multi_way_zip_join(tables, data_field_name, global_field_name) -> 'Table':
def multi_way_zip_join(tables, data_field_name, global_field_name) -> 'Table':
Copy link
Collaborator Author

@chrisvittal chrisvittal Jun 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe the behaviour of this will change in a backwards incompatible way. The only stabilization question that I think is unresolved is do we want these parameters to have default values?

Loading

Copy link
Collaborator

@patrick-schultz patrick-schultz Jun 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a default value is backwards compatible, so we can punt on that for now. But I also don't see any problem with just picking something reasonable like "row_fields" and "global_fields". I'm fine with either option, and ready to approve once you decide.

Loading

Copy link
Collaborator Author

@chrisvittal chrisvittal Jun 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave them off for now then.

Loading

@danking danking merged commit de6aab9 into hail-is:master Jul 1, 2019
1 check passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants