-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hail] Fix hadoop_ls
to glob
#7611
Conversation
Worth adding a test? |
@konradjk Python tests exist https://github.com/hail-is/hail/blob/master/hail/python/test/hail/utils/test_utils.py#L114 hail/hail/python/hail/fs/fs.py Line 75 in d65959f
edit: GitHub is fancy |
One that uses a glob though! I don’t see one at least. Maybe I missed (though I can’t imagine since it should have failed that test before this) |
You’re right, it could be useful to have a scala-specific test, but any breaking changes away from old ls behavior will cause the hadoop_ls test to fail (since Python presents our public interface, the more important single test to have) edit: iPhone typos |
yeah, will add a test for the new functionality though |
Out of curiosity, what's different about |
self.assertEqual is unittest style. We use pytest now, which rewrites Python assert statements to provide good failure messages. New code should use |
Somehow block matrix tests seem to be failing on this PR, both for the doctests and for the regular python tests. |
No description provided.