[hail] Fix hadoop_ls to glob

[tpoterba]

No description provided.

[konradjk]

Worth adding a test?

[akotlar]

@konradjk Python tests exist

https://github.com/hail-is/hail/blob/master/hail/python/test/hail/utils/test_utils.py#L114

hail/hail/python/hail/fs/fs.py

Line 75 in d65959f

r = Env.jutils().ls(path, Env.hc()._jhc)

edit: GitHub is fancy

[konradjk]

One that uses a glob though! I don’t see one at least. Maybe I missed (though I can’t imagine since it should have failed that test before this)

[akotlar]

You’re right, it could be useful to have a scala-specific test, but any breaking changes away from old ls behavior will cause the hadoop_ls test to fail (since Python presents our public interface, the more important single test to have)

edit: iPhone typos

[tpoterba]

yeah, will add a test for the new functionality though

[konradjk]

Out of curiosity, what's different about assert and the self.assertEqual?

[tpoterba]

self.assertEqual is unittest style. We use pytest now, which rewrites Python assert statements to provide good failure messages. New code should use assert, I think.

[johnc1231]

Somehow block matrix tests seem to be failing on this PR, both for the doctests and for the regular python tests.