Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[batch] shorten worker timeout #7972

Merged
merged 2 commits into from Jan 27, 2020
Merged

Conversation

cseed
Copy link
Collaborator

@cseed cseed commented Jan 27, 2020

After watching batch a bit, it is clear 5m is way too long.

@@ -34,7 +34,7 @@
configure_logging()
log = logging.getLogger('batch-worker')

MAX_IDLE_TIME_MSECS = 5 * 60 * 1000
MAX_IDLE_TIME_MSECS = 30 * 1000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! That seems aggressive. But I guess if the startup time is approximately 60-90 seconds then this makes sense?

Copy link
Collaborator Author

@cseed cseed Jan 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So basically watching batch load, if there's no work to do now, there won't be work to do for a while.

Here is an example: Konrad has big, slow jobs that gate many (~3K) medium fast jobs. So when a big job finishes, we spin up 3K cores and run jobs that take 5m. Then we hang out for 5m more waiting for work (there is none), and then wind down, making the node usage about 50% efficient.

I actually want to make it smaller (5s? ... long enough that children of any jobs that just finished will get rescheduled) and add a minimum up time of 1m (since we pay for at least one minute of compute). So I was planning to make it more aggressive in a later PR.

We need to start scraping the database and analyzing it. We could actually quantify this explicitly.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The startup seems closer to 1-2m.

@danking danking merged commit 855b48d into hail-is:master Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants