Skip to content

Commit

Permalink
getredash#121: mobile tweaks
Browse files Browse the repository at this point in the history
  • Loading branch information
amirnissim committed Mar 11, 2014
1 parent f01d224 commit 7618fc9
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 4 deletions.
10 changes: 10 additions & 0 deletions rd_ui/app/styles/redash.css
Expand Up @@ -235,4 +235,14 @@ textarea.rd-form-control {
}
visualization-renderer > div {
overflow: scroll;
}

/*
bootstrap's hidden-xs class adds display:block when not hidden
use this class when you need to keep the original display value
*/
@media (max-width: 767px) {
.rd-hidden-xs {
display: none !important;
}
}
30 changes: 26 additions & 4 deletions rd_ui/app/views/queryview.html
Expand Up @@ -14,18 +14,40 @@ <h2>
<span ng-show="!isQueryVisible">View Query</span>
<span ng-show="isQueryVisible">Hide Query</span>
</button>
<button class="btn btn-default" ng-show="canEdit" ng-click="toggleEdit()">
<button class="btn btn-default rd-hidden-xs" ng-show="canEdit" ng-click="toggleEdit()">
<span class="glyphicon glyphicon-edit"></span>
<span ng-show="isEditing"> Done</span>
<span ng-show="!isEditing"> Edit</span>
</button>
<button type="button" class="btn btn-default" ng-click="duplicateQuery()">
<button class="btn btn-default rd-hidden-xs" ng-click="duplicateQuery()">
<span class="glyphicon glyphicon-share-alt"></span> Duplicate
</button>
<a class="btn btn-primary" ng-disabled="queryExecuting || !queryResult.getData()" ng-href="{{dataUri}}" download="{{dataFilename}}" target="_self"><span class="glyphicon glyphicon-cloud-download"></span> Download
<a class="btn btn-primary" ng-disabled="queryExecuting || !queryResult.getData()" ng-href="{{dataUri}}" download="{{dataFilename}}" target="_self">
<span class="glyphicon glyphicon-cloud-download"></span>
<span class="rd-hidden-xs">Download</span>
</a>
</span>
</h2>

<div class="visible-xs">
<p>
<em>{{ query.description }}</em>
</p>
<p>
<span class="text-muted">Last update </span>
<strong am-time-ago="queryResult.query_result.retrieved_at"></strong>
&nbsp;
<span class="text-muted">Created By </span>
<strong>{{query.user.name}}</strong>
&nbsp;
<span class="text-muted">Runtime </span>
<strong ng-show="!queryExecuting">{{queryResult.getRuntime() | durationHumanize}}</strong>
<span ng-show="queryExecuting">Running&hellip;</span>
&nbsp;
<span class="text-muted">Rows </span>
<strong>{{queryResult.getData().length}}</strong>
</p>
</div>
</div>
</div>

Expand Down Expand Up @@ -72,7 +94,7 @@ <h2>
</div>

<div class="row">
<div class="col-lg-3">
<div class="col-lg-3 rd-hidden-xs">
<p>
<em>
<edit-in-place editable="isEditing" editor="textarea" placeholder="No description" ignore-blanks='false' value="query.description"></edit-in-place>
Expand Down

0 comments on commit 7618fc9

Please sign in to comment.