Fixing bug where tags added via autocomplete did not respect "maxTags…

…" option
hailwood · Jul 19, 2012 · 645558d · 645558d
1 parent 6ca832c
commit 645558d
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 6 deletions.
diff --git a/js/tagit-themeroller.js b/js/tagit-themeroller.js
@@ -39,6 +39,7 @@
             tagsChanged:function (tagValue, action, element) {
                 ;
             },
+            maxTags: undefined,
             //should 'paste' event trigger 'blur', thus potentially adding a new tag
             // (true for backwards compatibility)
             blurOnPaste:true
@@ -115,10 +116,16 @@
             this.options.select = function (event, ui) {
                 self.input.data('autoCompleteTag', true);
                 clearTimeout(self.timer);
-                if (ui.item.label === undefined)
-                    self._addTag(ui.item.value);
-                else
-                    self._addTag(ui.item.label, ui.item.value);
+                if (self.options.maxTags !== undefined && self.tagsArray.length == self.options.maxTags) {
+                    self.input.val("");
+                }
+                else {
+                    if (ui.item.label === undefined)
+                        self._addTag(ui.item.value);
+                    else
+                        self._addTag(ui.item.label, ui.item.value);
+                }
+
                 return false;
             }
 

diff --git a/js/tagit.js b/js/tagit.js
@@ -39,6 +39,7 @@
             tagsChanged:function (tagValue, action, element) {
                 ;
             },
+            maxTags:undefined,
             //should 'paste' event trigger 'blur', thus potentially adding a new tag
             // (true for backwards compatibility)
             blurOnPaste:true
@@ -114,14 +115,20 @@
             this.options.source = this.options.tagSource;
             this.options.select = function (event, ui) {
                 self.input.data('autoCompleteTag', true);
-                clearTimeout(self.timer);
+            clearTimeout(self.timer);
+            if (self.options.maxTags !== undefined && self.tagsArray.length == self.options.maxTags) {
+                self.input.val("");
+            }
+            else {
                 if (ui.item.label === undefined)
                     self._addTag(ui.item.value);
                 else
                     self._addTag(ui.item.label, ui.item.value);
-                return false;
             }
 
+            return false;
+        },
+
             this.options.focus = function (event, ui) {
                 if (ui.item.label !== undefined && /^key/.test(event.originalEvent.originalEvent.type)) {
                     self.input.val(ui.item.label);