Fix/configure Style/AccessorGrouping cop.

hainesr · May 23, 2021 · 201ad14 · 201ad14
1 parent fa5cfcd
commit 201ad14
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 11 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -64,6 +64,11 @@ Naming/VariableNumber:
   Exclude:
     - 'test/file_permissions_test.rb'
 
+# Need to allow accessors in Entry to be separated for doc purposes.
+Style/AccessorGrouping:
+  Exclude:
+    - 'lib/zip/entry.rb'
+
 # Set a consistent way of checking types.
 Style/ClassCheck:
   EnforcedStyle: kind_of?

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -51,15 +51,6 @@ Naming/AccessorMethodName:
     - 'lib/zip/input_stream.rb'
     - 'lib/zip/streamable_stream.rb'
 
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: separated, grouped
-Style/AccessorGrouping:
-  Exclude:
-    - 'lib/zip/decompressor.rb'
-    - 'lib/zip/entry.rb'
-
 # Offense count: 7
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.

diff --git a/lib/zip/decompressor.rb b/lib/zip/decompressor.rb
@@ -16,8 +16,7 @@ def self.find_by_compression_method(compression_method)
       decompressor_classes[compression_method]
     end
 
-    attr_reader :input_stream
-    attr_reader :decompressed_size
+    attr_reader :decompressed_size, :input_stream
 
     def initialize(input_stream, decompressed_size = nil)
       super()