Use named parameters for File::split.

hainesr · Jun 13, 2021 · 4936d9a · 4936d9a
1 parent ccb5641
commit 4936d9a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -107,13 +107,6 @@ Style/NumericPredicate:
     - 'lib/zip/ioextras/abstract_input_stream.rb'
     - 'test/test_helper.rb'
 
-# Offense count: 1
-# Configuration parameters: AllowedMethods.
-# AllowedMethods: respond_to_missing?
-Style/OptionalBooleanParameter:
-  Exclude:
-    - 'lib/zip/file_split.rb'
-
 # Offense count: 29
 # Cop supports --auto-correct.
 Style/RedundantRegexpEscape:

diff --git a/lib/zip/file_split.rb b/lib/zip/file_split.rb
@@ -63,7 +63,10 @@ def save_splited_part(zip_file, partial_zip_file_name, zip_file_size, szip_file_
     end
 
     # Splits an archive into parts with segment size
-    def split(zip_file_name, segment_size = MAX_SEGMENT_SIZE, delete_zip_file = true, partial_zip_file_name = nil)
+    def split(
+      zip_file_name, segment_size: MAX_SEGMENT_SIZE,
+      delete_original: true, partial_zip_file_name: nil
+    )
       raise Error, "File #{zip_file_name} not found" unless ::File.exist?(zip_file_name)
       raise Errno::ENOENT, zip_file_name unless ::File.readable?(zip_file_name)
 
@@ -81,7 +84,7 @@ def split(zip_file_name, segment_size = MAX_SEGMENT_SIZE, delete_zip_file = true
           save_splited_part(zip_file, partial_zip_file_name, zip_file_size, szip_file_index, segment_size, segment_count)
         end
       end
-      ::File.delete(zip_file_name) if delete_zip_file
+      ::File.delete(zip_file_name) if delete_original
       szip_file_index
     end
   end

diff --git a/test/file_split_test.rb b/test/file_split_test.rb
@@ -27,7 +27,9 @@ def test_split_method_respond
   end
 
   def test_split
-    result = ::Zip::File.split(TEST_ZIP.zip_name, 65_536, false)
+    result = ::Zip::File.split(
+      TEST_ZIP.zip_name, segment_size: 65_536, delete_original: false
+    )
 
     return if result.nil?