Fix Style/Semicolon cop.

hainesr · May 1, 2018 · ae4cae0 · ae4cae0
1 parent 122ccc4
commit ae4cae0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/.rubocop_rubyzip.yml b/.rubocop_rubyzip.yml
@@ -327,13 +327,6 @@ Style/SafeNavigation:
     - 'test/filesystem/file_stat_test.rb'
     - 'test/test_helper.rb'
 
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: AllowAsExpressionSeparator.
-Style/Semicolon:
-  Exclude:
-    - 'test/file_test.rb'
-
 # Offense count: 8
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.

diff --git a/test/file_test.rb b/test/file_test.rb
@@ -185,8 +185,9 @@ def test_add_existing_entry_name_replace
     replacedEntry = nil
     ::Zip::File.open(TEST_ZIP.zip_name) do |zf|
       replacedEntry = zf.entries.first.name
-      zf.add(replacedEntry, 'test/data/file2.txt') { gotCalled = true; true }
+      gotCalled = zf.add(replacedEntry, 'test/data/file2.txt') { true }
     end
+
     assert(gotCalled)
     ::Zip::File.open(TEST_ZIP.zip_name) do |zf|
       assert_contains(zf, replacedEntry, 'test/data/file2.txt')
@@ -296,7 +297,7 @@ def test_rename_to_existing_entry_overwrite
     renamedEntryName = nil
     ::Zip::File.open(TEST_ZIP.zip_name) do |zf|
       renamedEntryName = zf.entries[0].name
-      zf.rename(zf.entries[0], zf.entries[1].name) { gotCalled = true; true }
+      gotCalled = zf.rename(zf.entries[0], zf.entries[1].name) { true }
     end
 
     assert(gotCalled)