Skip to content

Commit

Permalink
Configure Naming/MemoizedInstanceVariableName cop.
Browse files Browse the repository at this point in the history
  • Loading branch information
hainesr committed Sep 22, 2019
1 parent 2db7342 commit f3f478d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
6 changes: 6 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ Lint/UselessComparison:
Exclude:
- 'test/entry_test.rb'

# Rubocop confuses these as instances of "memoization".
Naming/MemoizedInstanceVariableName:
Exclude:
- 'lib/zip/extra_field/old_unix.rb'
- 'lib/zip/extra_field/unix.rb'

# Allow this multi-line block chain as it actually reads better
# than the alternatives.
Style/MultilineBlockChain:
Expand Down
8 changes: 0 additions & 8 deletions .rubocop_rubyzip.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,6 @@ Naming/AccessorMethodName:
- 'lib/zip/streamable_stream.rb'
- 'test/file_permissions_test.rb'

# Offense count: 2
# Configuration parameters: EnforcedStyleForLeadingUnderscores.
# SupportedStylesForLeadingUnderscores: disallowed, required, optional
Naming/MemoizedInstanceVariableName:
Exclude:
- 'lib/zip/extra_field/old_unix.rb'
- 'lib/zip/extra_field/unix.rb'

# Offense count: 18
# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
Naming/UncommunicativeBlockParamName:
Expand Down

0 comments on commit f3f478d

Please sign in to comment.