Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function resolving in IDL #2

Merged
merged 2 commits into from Jan 24, 2018

Conversation

nathaniel
Copy link

The existing resolve_routine calls in bdtri.pro and pdtri.pro were not
working and not necessary. Remove those calls, and put the functions
that needed resolving at the front of their files, so they are
automatically compiled when the file's main function is called. Update
common block specifications to work with the new order.

(resolve_routine calls didn't work without /COMPILE_FULL_FILE keyword, because
"When compiling a file to find a specified routine, IDL normally stops compiling when the desired routine (Name) is found. If set, COMPILE_FULL_FILE compiles the entire file."
See http://www.harrisgeospatial.com/docs/RESOLVE_ROUTINE.html )

Changing the order of the functions so the last one in the file is the one whose name matches the filename, eliminates the need for resolve_routines call entirely.

I appreciate this library, glad to contribute.
-- Nathaniel

Nathaniel Cunningham and others added 2 commits January 19, 2018 12:46
The existing resolve_routine calls in bdtri.pro and pdtri.pro were not
working and not necessary. Remove those calls, and put the functions
that needed resolving at the front of their files, so they are
automatically compiled when the file's main function is called.
@hainest hainest merged commit 5eb2122 into hainest:master Jan 24, 2018
@hainest
Copy link
Owner

hainest commented Jan 24, 2018

Thanks, Nathaniel! To be honest, I only made the IDL version to get used to using the language. I also only tested it using GDL, so I'm not surprised there are some bugs. Glad you found it useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants