"gomplate -in flibbit" should produce an error

[docwhat]

I would expect that non-flag arguments would raise an error in gomplate.

Expected:

$ gomplate -in flibbit
I don't know what to do with 'flibbit'
# non-zero exit code
$

Actual:

$ gomplate -in flibbit
n<no newline> 
# zero exit code
$

I got bit by this because I typed -in instead of --in and spent a while trying to figure out what I did wrong.

FYI: -in can be rewritten as --in 'n'

[hairyhenderson]

Thanks for reporting this, @docwhat! I agree - that's a bit odd. This used to be the case, but I think additional args are silently ignored ever since I moved to using cobra for parsing args.

[docwhat]

When I was using kingpin I had a similar problem; I was not checking all the error conditions.

[docwhat]

Reading the docs on arguments, I think what you want is a line in the RootCmd section saying something like:

...
Args: NoArgs,
...

But I'm not sure, since I'm just speed reading the docs and change history of cobra.

[docwhat]

@hairyhenderson

P.S. For macOS users Homebrew/homebrew-core#15811

[hairyhenderson]

thanks @docwhat - I already have a tap at https://github.com/hairyhenderson/homebrew-tap, but being in core would be cool!

[drmdrew]

@hairyhenderson this looks to have a quick fix so I submitted PR #208 that registers cobra.NoArgs for the rootCmd as mentioned by @docwhat earlier #192 (comment)