Fixing bug with 'has' and 'datasource' around referencing sub-maps in nested maps #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… nested maps Signed-off-by: Dave Henderson <dhenderson@gmail.com>
hairyhenderson
force-pushed
the
fix-nested-map-bugs-134
branch
from
3608aca
to
f358f18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134
This loosens the signature of
hasso that anymapcan be provided. It means usingreflect(😨), but I think it's necessary in this case.I also found an issue where
{{ (ds "d").foo.bar }}would fail, so I fixed that. The fix involved moving fromjson.Unmarshaltoyaml.Unmarshal- seems they behave slightly differently. This is just fine, given that YAML is a superset of JSON. The only catch is that the parser isn't as strict so things that failed to parse before will now parse... ¯\_(ツ)_/¯Signed-off-by: Dave Henderson dhenderson@gmail.com