Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add solaris-amd64 build target #141

Merged
merged 1 commit into from May 19, 2017
Merged

Add solaris-amd64 build target #141

merged 1 commit into from May 19, 2017

Conversation

jen20
Copy link
Contributor

@jen20 jen20 commented May 18, 2017

It would be great if there was an official release for solaris/amd64 which is the platform I'm using primarily - this PR adds it as a target in Makefile, which as far as I can see is the only change which needs making?

@hairyhenderson
Copy link
Owner

Hey, @jen20 - thanks for another great PR!

This should be the only change you need. Some platforms also get a slim variant, compressed with UPX, but as far as I can tell, UPX doesn't support Solaris, so that doesn't apply in this case.

hairyhenderson
hairyhenderson approved these changes May 19, 2017
View reviewed changes
Copy link
Owner

@hairyhenderson hairyhenderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hairyhenderson hairyhenderson merged commit 811a4b7 into hairyhenderson:master May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hairyhenderson hairyhenderson hairyhenderson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jen20 @hairyhenderson