Fixing MIME type precedence #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
hairyhenderson
force-pushed
the
fix-mime-type-precedence
branch
from
70525f6
to
f52eb1a
Compare
hairyhenderson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #370, closes #373
This defers the mime type calculation until it's actually necessary. I've also severely simplified (and eliminated uses of)
NewSource. It can be deprecated/removed later. Also I've noticed thatExtandParamsaren't used at all, and contain info that can be easily calculated from the URL. And most (all?) of the properties of theSourcestruct should be unexported. But those things can (will!) happen in a followup PR.Signed-off-by: Dave Henderson dhenderson@gmail.com