Produce multi-platform Docker images #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhenderson
force-pushed
the
multi-platform-docker-image
branch
2 times, most recently
from
2919463
to
1633171
Compare
hairyhenderson
force-pushed
the
multi-platform-docker-image
branch
2 times, most recently
from
21d6417
to
da33e1c
Compare
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
hairyhenderson
force-pushed
the
multi-platform-docker-image
branch
from
da33e1c
to
44887b9
Compare
This was referenced Apr 21, 2020
glensc
reviewed
Sep 2, 2020
| run: make docker-images | ||
| - name: determine if this is a tag | ||
| run: | | ||
| if (git describe --abbrev=0 --exact-match &>/dev/null); then |
There was a problem hiding this comment.
you don't need subshell here:
if git describe --abbrev=0 --exact-match &>/dev/null; then
There was a problem hiding this comment.
thanks @glensc - this is a holdover from many copy-pastes ago... I'll happily merge a PR if you want to make the change 😉
There was a problem hiding this comment.
no worries. you can leave as is as well. totally up to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dave Henderson dhenderson@gmail.com