Memory Leak

[Robigus92]

After a double rotation of the SettingsActivity there are in heap memory 2 instances more of:

class com.seafile.seadroid2.ui.fragment.SettingsFragment @ 0x12d1d800
class com.seafile.seadroid2.data.DataManager @ 0x12c88520
class com.seafile.seadroid2.SeafConnection @ 0x12d9b7c0
class com.seafile.seadroid2.ui.fragment.CustomPreferenceFragment$2 @ 0x12da8340
class com.seafile.seadroid2.ui.fragment.CustomPreferenceFragment$3 @ 0x12da8400
class com.seafile.seadroid2.ui.fragment.SettingsFragment$21 @ 0x12da8640
class com.seafile.seadroid2.ui.fragment.SettingsFragment$7 @ 0x12db31c0
class com.seafile.seadroid2.ui.fragment.SettingsFragment$2 @ 0x12da8d00
class com.seafile.seadroid2.ui.fragment.SettingsFragment$3 @ 0x12da8dc0
class com.seafile.seadroid2.ui.fragment.SettingsFragment$4 @ 0x12da8e80
class com.seafile.seadroid2.ui.fragment.SettingsFragment$6 @ 0x12db3100
class com.seafile.seadroid2.ui.fragment.SettingsFragment$11 @ 0x12db34c0
class com.seafile.seadroid2.ui.fragment.SettingsFragment$12 @ 0x12db3580
class com.seafile.seadroid2.ui.fragment.SettingsFragment$13 @ 0x12db3640
class com.seafile.seadroid2.ui.fragment.SettingsFragment$14 @ 0x12db3700
class com.seafile.seadroid2.ui.fragment.SettingsFragment$15 @ 0x12db37c0
class com.seafile.seadroid2.ui.fragment.SettingsFragment$16 @ 0x12db3880
class com.seafile.seadroid2.ui.CustomPreferenceManagerCompat$1 @ 0x12dc4100

It should not be like this because the rotations return to the same GUI state and the memory should stay in the same state as well. It could be a symptom of a bad management of the onCreate-onDestroy lifecycle.

I have encountered this problem on an Android emulator running 7.1.1 os version.